-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [M3-7786] - Convert isRestrictedGlobalGrantType
to Hook
#10203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through #10095's test steps and confirmed the disabled aspects for a restricted user's account were as expected.
Thanks for the test coverage - those initial cases at least look good for now.
Edit: pending typecheck and unit tests are no longer failing in CI - forgot about those. 👀
packages/manager/src/hooks/useRestrictedGlobalGrantCheck.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the hook tests! We don't have a ton of tests for hooks, so it's even more helpful to have these as extra examples for devs to refer to
Description 📝
By converting
isRestrictedGlobalGrantType
to a hook we can avoid having to pass ingrants
andprofile
and clean up the API.Changes 🔄
isRestrictedGlobalGrantType
utiluseRestrictedGlobalGrantCheck
hookTarget release date 🗓️
03/04/2024
Preview 📷
Before
After
How to test 🧪
There should be no functional changes, but see testing instructions: #10095
As an Author I have considered 🤔
Check all that apply